Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Script serialization #152

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Fix Script serialization #152

merged 1 commit into from
Nov 12, 2022

Conversation

SebastienGllmt
Copy link
Contributor

This fixes an issue in Script serialization where we were accidentally using tags instead of unsigned ints.

This was causing errors in round-trip serialization of the Script type

@SebastienGllmt SebastienGllmt added the bug Something isn't working label Nov 11, 2022
@SebastienGllmt SebastienGllmt self-assigned this Nov 11, 2022
rooooooooob
rooooooooob approved these changes Nov 12, 2022
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastienGllmt SebastienGllmt merged commit c67b3a2 into develop Nov 12, 2022
@SebastienGllmt SebastienGllmt deleted the fix-script-serialize branch November 12, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooooooooob rooooooooob rooooooooob approved these changes

Assignees

@SebastienGllmt SebastienGllmt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SebastienGllmt @rooooooooob