Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Into bytes instance for const size array-based wrapper types. #288

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Into bytes instance for const size array-based wrapper types. #288

merged 2 commits into from
Dec 27, 2023

Conversation

oskin1
Copy link
Contributor

@oskin1 oskin1 commented Dec 27, 2023

No description provided.

@rooooooooob
Copy link
Contributor

Should be possible to do From instead, see clippy lint that failed.

rooooooooob
rooooooooob approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastienGllmt SebastienGllmt merged commit 6e423ad into dcSpark:develop Dec 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooooooooob rooooooooob rooooooooob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oskin1 @rooooooooob @SebastienGllmt