Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt -> BigInteger #302

Merged
merged 1 commit into from
Jan 29, 2024
Merged

BigInt -> BigInteger #302

merged 1 commit into from
Jan 29, 2024

Conversation

rooooooooob
Copy link
Contributor

to avoid conflicts with JS's BigInt

Fixes #301

@rooooooooob
BigInt -> BigInteger
2a13763 
to avoid conflicts with JS's BigInt
@SebastienGllmt SebastienGllmt merged commit 6df7876 into develop Jan 29, 2024
1 check passed
@SebastienGllmt SebastienGllmt deleted the bigint-to-biginteger branch January 29, 2024 17:53
rooooooooob added a commit that referenced this pull request Jan 29, 2024
@rooooooooob
Fix for #302 / #296 conflict
7156ced 
I merged #296 thinking I would rebase #302 but before I could it was
merged.

This just renames BigInt -> BigInteger in the new BigInt tests
introduced in #296 which was done before the #302 renaming.
@rooooooooob rooooooooob mentioned this pull request Jan 29, 2024
Merged
rooooooooob added a commit that referenced this pull request Jan 30, 2024
@rooooooooob
Fix for #302 / #296 conflict (#303)
0940f0a 
I merged #296 thinking I would rebase #302 but before I could it was
merged.

This just renames BigInt -> BigInteger in the new BigInt tests
introduced in #296 which was done before the #302 renaming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename BigInt to something else
2 participants
@rooooooooob @SebastienGllmt