Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: nint deserialization below i64::MIN #32

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix: nint deserialization below i64::MIN #32

merged 1 commit into from
Mar 31, 2022

Conversation

SebastienGllmt
Copy link
Contributor

rooooooooob
rooooooooob approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be reviewing my own PR but if you're fine with the code changes then it LGTM. It's a small change anyway and has test cases.

@SebastienGllmt SebastienGllmt merged commit 1d59cb1 into develop Mar 31, 2022
@SebastienGllmt SebastienGllmt deleted the dcspark/nint-fix branch March 31, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooooooooob rooooooooob rooooooooob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastienGllmt @rooooooooob