feat: add native-script verify function #332
Conversation
There was a problem hiding this comment.
Two things:
-
We put these kinds of things in
utils.rsfiles instead ofmod.rs. Themod.rswe try and keep as auto-generated as possible (outside of module declarations and some imports). That way it doesn't get overwritten when we need to regenerate something when they update the cddl definitions. -
This should be in the
chain/rustcrate and then a simple binding over it for thechian/wasmcode so that way it's exposed for rust projects too.
Yes |
| @@ -68,6 +69,61 @@ impl NativeScript { | |||
| pub fn hash(&self) -> ScriptHash { | |||
| self.0.hash().into() | |||
| } | |||
|
|
|||
| pub fn verify( | |||
There was a problem hiding this comment.
I meant just a wrapper around the rust code to avoid duplicating logic e.g.:
self.0.verify(lower_bound, upper_bound, key_hashes.as_ref())^ untested but it's something like that
We have AsRef and Into/From to convert to/from the rust and WASM structs.
|
The checks fail with a clippy warning. Once that is fixed and the check passes I'll LGTM and merge it. Thanks. |
|
How long does it take for the new release? |
* feat: add native-script verify function
No description provided.