-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance Builders #333
Governance Builders #333
Conversation
Adds `VoteBuilder` and `ProposalBuilder` to facilitate creation of votes and voting proposals to transactions.
8475c99
to
4bf74bc
Compare
I'm just going to mark this as ready for review now. I haven't been able to test everything but I've been able to use the builders to make a few proposals (params, constitution, info) and vote on them (params, consitution). The hardfork one should be fine as there is just a version in it just like the constitution. I could test that too but I need more test ADA as the drep deposit is large. The only one I am worried about is the UpdateCommittee one but I'm not sure if I can even propose that without having any of the exisitng keys. I only tested DRep voting as I don't have a pool and am not a part of the constitutional committee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving modulo any other testing you might want to do
Somehow `coin` ended up here still after #333 despite being changed to `deposit`.
Somehow `coin` ended up here still after #333 despite being changed to `deposit`.
* Governance Builders Adds `VoteBuilder` and `ProposalBuilder` to facilitate creation of votes and voting proposals to transactions. * Hook Vote/Proposal Builders into TxBuilder/RedeemerBuilder * Fix deposit/required certs * Fix proposal deposits
Somehow `coin` ended up here still after #333 despite being changed to `deposit`.
Adds
VoteBuilder
andProposalBuilder
to facilitate creation of votes and voting proposals to transactions.Resolves #323