Governance Builders #333
Merged
Governance Builders #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `VoteBuilder` and `ProposalBuilder` to facilitate creation of votes and voting proposals to transactions.
rooooooooob
force-pushed
the
voting-builders
branch
from
8475c99
to
4bf74bc
Compare
|
I'm just going to mark this as ready for review now. I haven't been able to test everything but I've been able to use the builders to make a few proposals (params, constitution, info) and vote on them (params, consitution). The hardfork one should be fine as there is just a version in it just like the constitution. I could test that too but I need more test ADA as the drep deposit is large. The only one I am worried about is the UpdateCommittee one but I'm not sure if I can even propose that without having any of the exisitng keys. I only tested DRep voting as I don't have a pool and am not a part of the constitutional committee. |
SebastienGllmt
approved these changes
Jul 10, 2024
rooooooooob
added a commit
that referenced
this pull request
Jul 16, 2024
Somehow `coin` ended up here still after #333 despite being changed to `deposit`.
rooooooooob
added a commit
that referenced
this pull request
Jul 16, 2024
Somehow `coin` ended up here still after #333 despite being changed to `deposit`.
rooooooooob
added a commit
that referenced
this pull request
Jul 23, 2024
* Governance Builders Adds `VoteBuilder` and `ProposalBuilder` to facilitate creation of votes and voting proposals to transactions. * Hook Vote/Proposal Builders into TxBuilder/RedeemerBuilder * Fix deposit/required certs * Fix proposal deposits
rooooooooob
added a commit
that referenced
this pull request
Jul 23, 2024
Somehow `coin` ended up here still after #333 despite being changed to `deposit`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
VoteBuilderandProposalBuilderto facilitate creation of votes and voting proposals to transactions.Resolves #323