wasm-bindgen: upgrade to 0.2.87 and remove serde-deserialize feature #335
Conversation
cml/wasm/Cargo.toml
Outdated
| wasm-bindgen = { version = "0.2" } |
There was a problem hiding this comment.
What about this version? Should we put it to 0.2.87 like all the others for consistency? Same for the multi-era crate. I think it was just on 0.2 due to copying an pasting dependencies at some point.
There was a problem hiding this comment.
I imagine every crate will resolve to the same version anyway. But probably yeah, if we pin one it's probably best to pin all of them.
There was a problem hiding this comment.
Although I'm still not really sure the pin is needed
multi-era/wasm/Cargo.toml
Outdated
| @@ -26,7 +26,7 @@ hex = "0.4.0" | |||
| linked-hash-map = "0.5.3" | |||
| serde_json = "1.0.57" | |||
| serde-wasm-bindgen = "0.4.5" | |||
| wasm-bindgen = { version = "0.2", features=["serde-serialize"] } | |||
| wasm-bindgen = { version = "0.2" } | |||
|
Why don't you bump to the latest version (0.2.92)? |
|
please upgrade to |
The main reason was that |
yes, that makes sense |
ecioppettini
deleted the
enzo/remove-serde-deserialize-feature-and-upgrade
branch
Removes the deprecated serde-serialize feature (which seems unused, but I'm not a 100% sure). Also upgrades the wasm-bindgen version. I'm actually not sure if the version pinning is needed for some reason, but this is the minimum version I needed to add this as a dependency in the milkomeda bridge.