Remove wasm-bindgen deps from rust #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust CML crates must use wasm-bindgen for enums as these are used from the WASM CML crates. Using noop_proc_macro we can replace the wasm_bindgen proc macro with a no-op that does nothing when consumed directly from rust. This is now locked behind a feature (used_from_wasm) as we can't just use cfg target checks as compiling the wasm crate (not using web-pack) would use the rust target and break. Crates using cml-chain and cml-multi-era from a wasm crate must specify this feature to activate the wasm_bindgen dependancy instead of the no-op macro.
rooooooooob
commented
Jul 16, 2024
|
|
||
| # only for declaring hash types | ||
| bech32 = "0.7.2" | ||
| hex = "0.4.0" | ||
|
|
||
| # non-wasm | ||
| noop_proc_macro = { version = "0.3.0" } |
There was a problem hiding this comment.
I had this as optional = true but for some reason when consuming it from dcspark-core/carp it would not be able to find the dependancy. Strangely having it as optional worked fine for the cml-chain dependency. Both were specified in the same way in the same Cargo.toml file in dcspark-core so I have no idea why this is the case.
There was a problem hiding this comment.
doesn't cml-chain have it as optional = false? which would be the same as not writing it
There was a problem hiding this comment.
Oops, I saw it specified and I guess my brain just read it as = true automatically. That makes sense now.
ecioppettini
approved these changes
Jul 16, 2024
rooooooooob
added a commit
that referenced
this pull request
Jul 23, 2024
Rust CML crates must use wasm-bindgen for enums as these are used from the WASM CML crates. Using noop_proc_macro we can replace the wasm_bindgen proc macro with a no-op that does nothing when consumed directly from rust. This is now locked behind a feature (used_from_wasm) as we can't just use cfg target checks as compiling the wasm crate (not using web-pack) would use the rust target and break. Crates using cml-chain and cml-multi-era from a wasm crate must specify this feature to activate the wasm_bindgen dependancy instead of the no-op macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust CML crates must use wasm-bindgen for enums as these are used from the WASM CML crates.
Using noop_proc_macro we can replace the wasm_bindgen proc macro with a no-op that does nothing when consumed directly from rust.
This is now locked behind a feature (used_from_wasm) as we can't just use cfg target checks as compiling the wasm crate (not using web-pack) would use the rust target and break.
Crates using cml-chain and cml-multi-era from a wasm crate must specify this feature to activate the wasm_bindgen dependancy instead of the no-op macro.