Slot/TransactionIndex/CertificateIndex changes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `Slot` was changed to `BigNum`, it wasn't updated for wasm-suitable API in every location (still taken by value in some spots), so this includes fixes for that. Also updates the changes in #33 to work with the global `Slot` change that was done prior. `TransactionIndex` and `CertificateIndex` were globablly changed to `BigNum` for consistency and because we'll likely run into those on-chain if they are already there inside of pointer addresses. There still remains other uses of `u32`, especially in lower priority structures like block headers and updates. Those should be fine for now as we might end up removing `BigNum` soon anyway, and those are not as succeptible to random users posting them on-chain. Warning in tests were fixed as well.
SebastienGllmt
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Slotwas changed toBigNum, it wasn't updated for wasm-suitableAPI in every location (still taken by value in some spots), so this
includes fixes for that.
Also updates the changes in #33 to work with the global
Slotchangethat was done prior.
TransactionIndexandCertificateIndexwere globablly changed toBigNumfor consistency and because we'll likely run into thoseon-chain if they are already there inside of pointer addresses.
There still remains other uses of
u32, especially in lower prioritystructures like block headers and updates. Those should be fine for now
as we might end up removing
BigNumsoon anyway, and those are not assucceptible to random users posting them on-chain.
Warning in tests were fixed as well.