Enum length-check fixes + Enum optional field support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #175 Now properly checks all lengths for all variants to ensure that overlapping types parse the correct variant instead of prematurely thinking it's a subset of one. Also fixes having CBORReadLen contributions from previous variants that tried to parse from contributing to later variant parses (possibly causing issues if it meant it already hit the limit). Includes support for optional fields within enums that get inlined. Tests for both cases.
tests/preserve-encodings/input.cddl
Outdated
| @@ -111,4 +111,33 @@ bounds_group_choice = [ | |||
| hash // | |||
| ; @name c | |||
| 1, x: hash, y: hash | |||
| ] | |||
|
|
|||
| ; just testing this compiles (for now? possibly have full tests in a later commit) | |||
There was a problem hiding this comment.
Is this comment meant to be merged in as-is?
There was a problem hiding this comment.
I wasn't sure if it was worth it to put in preserve-encodings tests since all the deser code should be tested in the other tests (the base group choice one + other tests in general) so the big worry was just about it compiling. I guess it can't hurt to have better coverage though so I added two new cases for those two definitions in the last commit.
SebastienGllmt
approved these changes
Dec 15, 2023
rooooooooob
added a commit
to dcSpark/cardano-multiplatform-lib
that referenced
this pull request
Feb 27, 2024
Regen using dcSpark/cddl-codegen#225 to fix new clippy lint causing several open PRs to fail This also includes some enum deserialization check improvements introduced in dcSpark/cddl-codegen#217 Also some minor updates to the .cddl spec to fix names in a few places
rooooooooob
added a commit
to dcSpark/cardano-multiplatform-lib
that referenced
this pull request
Mar 7, 2024
Regen using dcSpark/cddl-codegen#225 to fix new clippy lint causing several open PRs to fail This also includes some enum deserialization check improvements introduced in dcSpark/cddl-codegen#217 Also some minor updates to the .cddl spec to fix names in a few places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
Now properly checks all lengths for all variants to ensure that overlapping types parse the correct variant instead of prematurely thinking it's a subset of one.
Also fixes having CBORReadLen contributions from previous variants that tried to parse from contributing to later variant parses (possibly causing issues if it meant it already hit the limit).
Includes support for optional fields within enums that get inlined.
Tests for both cases.