Better file errors + common import import #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better error checks/messages for file missing related errors to help debugging as the error was incredibly opaque as to where it originated. * Imports correctly from the common import override in `serialization.rs` files instead of relying on the `import super::*;` which only works when it's not overrided.
rooooooooob
commented
May 14, 2024
| @@ -1028,6 +1038,9 @@ impl GenerationScope { | |||
| export_raw_bytes_encoding_trait: bool, | |||
| cli: &Cli, | |||
| ) -> std::io::Result<()> { | |||
| // check it exists here to get clearer error message | |||
There was a problem hiding this comment.
this is checked all the time instead of just when it's overridden as we still pull out the Cargo.toml files from here regardless.
SebastienGllmt
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error checks/messages for file missing related errors to help debugging as the error was incredibly opaque as to where it originated.
Imports correctly from the common import override in
serialization.rsfiles instead of relying on theimport super::*;which only works when it's not overrided.