Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window jumps to (0,0) upon first animation #9

Closed
dccsillag opened this issue Jul 29, 2021 · 2 comments
Closed

Window jumps to (0,0) upon first animation #9

dccsillag opened this issue Jul 29, 2021 · 2 comments

Comments

@dccsillag
Copy link
Owner

I've finally been able to reliably reproduce this.

Follow the steps:

  • Create a window;
  • Move it;

Instead of simply animating from where it was to where you moved it, the window will have jumped to (0,0) and then animated to where it was supposed to be.

@dccsillag
Copy link
Owner Author

dccsillag commented Jul 29, 2021

It's worth noting that this does not happen in @alexfrederiksen's PR. After looking at his code, my guess is that it has something to do with the initialization of the w->animation_* members in win.c.

dccsillag added a commit that referenced this issue Jul 29, 2021
@dccsillag
Copy link
Owner Author

Solved.

What happened is that animation_{x,y} were both equal to 0. Now they get properly initialized via pending_g.
Also, we take some care regarding animation_progress -- values in [0,1) denote that we are in the middle of an animation, while anything else means that we are not. Plus some care in managing old_win_image.

hydroxycarbamide pushed a commit to hydroxycarbamide/picom that referenced this issue Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant