Add experimental container mode in the CLI #285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
force-pushed
the
container-mode-in-cli
branch
6 times, most recently
from
1ac298a to
3d802a4
Compare
The general syntax for macro defines in macro files is: %$macro_name something but you can also have a () after the macro name like in: %py3_build() \ which would not get matched by the original regex as it expected the macro name to be followed by whitespace. We therefore need to extend it and also match open braces
We were so far only assuming that SPEC level macros are from the preamble, but these can be also %define or %global macros from the current spec. Hence we look for them via the macro define find function as well, in case we find nothing in the preamble
dcermak
force-pushed
the
container-mode-in-cli
branch
from
3d802a4 to
ac330cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.