Skip to content

Commit

Permalink
[bp/1.28] Fix build error with maxmind if http3 is disabled (#33638)
Browse files Browse the repository at this point in the history
`maxmind` is causing the build to not honor the flag `--//bazel:http3=False`: The
define `ENVOY_ENABLE_QUIC` is still being passed to the compiler. This
causes code that rely on the presence (or not) of that define to behave
wrongly.

I am not 100% sure of what causes it, but Bazel doc says 1) to not use
`bind` and 2) that `bind` and `select` do not play well together: https://bazel.build/reference/be/workspace#bind

By removing the `bind` and pointing directly to the actual dependency in
`maxmind` BUILD file, we fix this issue.

Backport of envoyproxy/envoy#33638

Signed-off-by: Jonh Wendell <jwendell@redhat.com>
  • Loading branch information
jwendell authored and dcillera committed Aug 13, 2024
1 parent 62072fd commit 4a259b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source/extensions/geoip_providers/maxmind/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ envoy_cc_library(
hdrs = ["geoip_provider.h"],
tags = ["skip_on_windows"],
deps = [
"//bazel/foreign_cc:maxmind_linux_darwin",
"//bazel/foreign_cc:maxmind_linux",
"//envoy/geoip:geoip_provider_driver_interface",
"@envoy_api//envoy/extensions/geoip_providers/maxmind/v3:pkg_cc_proto",
],
Expand Down

0 comments on commit 4a259b3

Please sign in to comment.