Fix service uninstall when the env var is null in marathon json #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsancio
reviewed
Feb 23, 2018
| appJson.add( | ||
| envJsonField, | ||
| Json.fromJsonObject( | ||
| appJson(envJsonField).get.asObject.get.add(SdkUninstallEnvvar, Json.fromString("true")) | ||
| appJson(envJsonField) | ||
| .map(_.asObject.get) |
There was a problem hiding this comment.
.flatMap(_.asObject). We should feel uncomfortable when we see a .get in the code. :)
takirala
force-pushed
the
fix-uninstaller
branch
from
346c6ce
to
e9dc97e
Compare
takirala
added a commit
that referenced
this pull request
Feb 24, 2018
takirala
added a commit
that referenced
this pull request
Feb 26, 2018
* Handle the case when the env var is null in marathon json during uninstall (#719) * Bump version to 0.5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address DCOS-21374