Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform port check for node availability #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Perform port check for node availability #25

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2019

This PR adds a port check (22) and blocks for 10 minutes until all designated hosts become available. To accomplish this fact gathering has to be disabled first, and then re-enabled after the checks.

Copy link
Contributor

@fatz fatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please drop gathering facts its already done in the next step

hosts: all
tasks:
- name: Now lets gather facts
setup:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already done in the next step

wait_for:
port: 22
timeout: 660
state: started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We could add it for now

@ghost
Copy link
Author

ghost commented Jun 3, 2019

@geekbass had some concerns though

@sebbrandt87 sebbrandt87 force-pushed the master branch 3 times, most recently from bc651a0 to 294e20a Compare July 24, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant