Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from dep to go mod #64

Merged
merged 6 commits into from
Jan 8, 2019
Merged

Switch from dep to go mod #64

merged 6 commits into from
Jan 8, 2019

Conversation

br-lewis
Copy link
Contributor

@br-lewis br-lewis commented Nov 30, 2018

Switch from dep to go mod

This PR changes dcos-go to handle dependencies using go mod rather than dep.

Note: in order to avoid a dependency casing conflict (see here), this PR pins github.com/docker/docker and github.com/docker/distribution to their current latest commit on master, it won't track changes in those masters automatically but this may not be desirable for us.

Checklist

  • ~80% unit test coverage?
  • Updated README.md?
  • Completed sections of this PR template?
  • Edited all sections [IN BRACKETS]

Overview of Change

Go modules are the canonical method of dependency management now with Go 1.11. It also allows dcos-go to exist outside of $GOPATH

Affected Usage

This shouldn't affect usage of other libraries.

Copy link
Contributor

@gpaul gpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy days!

Copy link
Contributor

@drewvanstone drewvanstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small typos but otherwise looks good.

As an aside, I think moving away from vendor directory would be good at some point. The community seems to be converging on project Athens. It's basically an append only artifact store for go modules. It means we could have repeatable builds without vendor checked into code.

README.md Outdated Show resolved Hide resolved
scripts/test.sh Outdated Show resolved Hide resolved
@br-lewis br-lewis merged commit 32a6938 into dcos:master Jan 8, 2019
@br-lewis br-lewis deleted the gomod branch January 8, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants