chore: upgrade lingui to 2.8.0 #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing with "npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with |
GeorgiSTodorov
previously approved these changes
May 20, 2019
brandonc
force-pushed
the
brandonc/lingui_2.8.0
branch
from
bea9d28 to
962206e
Compare
TattdCodeMonkey
approved these changes
Jun 20, 2019
GeorgiSTodorov
approved these changes
Jun 21, 2019
|
🎉 This PR is included in version 2.111.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I added a feature to lingui that allows a config file to be specified which really helps out with our externalplugins configuration. Therefore we no longer need to swap out config files when extracting messages.
The practical result is simplified lingui-extract and lingui-compile scripts
Testing
check out companion plugins-private PR https://github.com/mesosphere/dcos-ui-plugins-private/pull/1008
npm run util:lingui:extractnpm run util:lingui:compile(With and without plugins-ee symlink)
Dependencies
I had to rename the .linguirc config file in the plugins-private repo (https://github.com/mesosphere/dcos-ui-plugins-private/pull/1008)