Updated 'no_shipping' and 'rm' options for PayPalPaymentsForm #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shipping option 2 prompts the buyer for an address, and requires one before payment is taken. PayPal 'rm' variable specifies the return FORM method used upon success payment: Allowable values are: 0 . all shopping cart payments use the GET method 1 . the buyer.s browser is redirected to the return URL by using the GET method, but no payment variables are included 2 . the buyer.s browser is redirected to the return URL by using the POST method, and all payment variables are included The default is 0. Note: The rm variable takes effect only if the return variable is set.
|
Hi @dcramer , I am doing another project and would like to use your fork but need the extra paypal parameters support. Are you going to merge this please? |
added 4 commits
September 4, 2012 15:29
…e_url' header image support to form. The method `<PayPalPaymentForm>.render_as_GET_url()` and it's sandbox version can be used to directly redirect to PayPal payment page from view that performs pre-payment processing; for example a view that check if shipping information was entered and is correct, to confirming that inventory is still adequate for order. Readme documentation was updated to reflect these changes.
For example in Eclipse one can enable "Show whitespace characters" which helps with code blocks and for this tabs are a better choice than spaces. Another plus once can easily specify 'tab' character visual length which you can't do for spaces; hence this developer uses tabs against 'PEP-8' strong recommendations.
pigletto
pushed a commit
to pigletto/django-paypal
that referenced
this pull request
Aug 7, 2014
fixes markup for signal documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From was missing shipping option 2 which prompts the buyer for an address, and requires one before
payment is taken. Also it was missing PayPal 'rm' variable which specifies the return FORM method used
upon success payment:
Allowable values are:
0 . all shopping cart payments use the GET method
1 . the buyer.s browser is redirected to the return URL by using the GET method, but no payment variables are included
2 . the buyer.s browser is redirected to the return URL by using the POST method, and all payment variables are included
The default is 0. Note: The rm variable takes effect only if the return variable is set.