Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export newPeerConfig and newServerPeer #9

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Export newPeerConfig and newServerPeer #9

merged 1 commit into from
Oct 31, 2022

Conversation

martonp
Copy link

@martonp martonp commented Oct 28, 2022

These functions are need to public to be able to add peers to an existing ChainService.

Already merged in btc neutrino:
lightninglabs/neutrino@b30b1ca

@martonp
Export newPeerConfig and newServerPeer
54f5aad 
These functions are need to public to be able to add peers to an
existing ChainService.
chappjc
chappjc approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

In dcrdex how will we add peers? I figured we'd solve the dcrdex issue by feeding a list of peers when doing neutrino.NewChainService(neutrino.Config{.

@chappjc
Copy link
Member

chappjc commented Oct 28, 2022

Ah! decred/dcrdex#1931

@martonp martonp mentioned this pull request Oct 30, 2022
Merged
@chappjc chappjc merged commit f296bfa into dcrlabs:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chappjc chappjc chappjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martonp @chappjc