Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure proper CMake version present #55

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

henryiii
Copy link
Contributor

This should match your cmake_minimum_version.

(By the way, does threading make any sense? I could update this for free-threaded Python quite easily if it does).

@dcwatson
Copy link
Owner

I haven't looked into free-threading Python yet (apart from the talks I watched at PyCon!). I think this extension itself has very little use for threads, since libdeflate compressors/decompressors are not thread-safe themselves. If we ever implemented a higher-level chunked compression/decompression scheme (using multiple compressors/decompressors in separate threads), that would be another story, but I think that's out of scope for this library.

That said, threading in Python and calling deflate.gzip_compress on many chunks at once would be super useful. In fact, the whole reason I wrote this wrapper was to speed up a chunked encryption/compression library (https://github.com/imsweb/pzip). Being able to thread that will be a huge win - I did it in https://github.com/dcwatson/PZSwift and it performs great.

@dcwatson dcwatson merged commit 8e9844a into dcwatson:main May 29, 2024
9 checks passed
@henryiii henryiii deleted the patch-1 branch May 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants