Skip to content

Commit

Permalink
version bump and doc
Browse files Browse the repository at this point in the history
  • Loading branch information
Your Name committed Dec 21, 2024
1 parent 2b65155 commit 14fd46a
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"onCreateCommand": "cd back && poetry config virtualenvs.create false && poetry install && cd ../front/ && npm install",
"features": {
"ghcr.io/ddahan/feature-starter/poetry:latest": {
"version": "1.8.4"
"version": "1.8.5"
},
"ghcr.io/ddahan/feature-starter/custom_bashrc:latest": {},
"ghcr.io/devcontainers/features/node": {
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ services:
# pgAdmin service
########################################################################################
pgadmin:
image: "dpage/pgadmin4:8.13"
image: "dpage/pgadmin4:8.14"
environment:
- PGADMIN_DEFAULT_EMAIL=localuser@fast-batteries.ovh
- PGADMIN_DEFAULT_PASSWORD=localpassword
Expand Down
5 changes: 3 additions & 2 deletions back/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
[tool]

[tool.poetry]
name = "Batteries"
name = "fast-batteries"
version = "0.1.0"
package-mode = false
authors = ["David Dahan <david.dahan3@gmail.com>"]

readme = "README.md"

[tool.pytest.ini_options]
addopts = "--color=yes"
Expand Down
5 changes: 5 additions & 0 deletions doc/XX_developer_experience.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ Here is my experience trying to install clean linting with VS Code, FastAPI.
### ❌ Ruff Extension + Mypy Extension + Pylance Extension (with type checking off)
- In this case, there is no overlapping as Mypy only warns on typing, and Ruff only on other linting rules.
- But Mypy is very slow, and only run at saving


## Dev-dependencies

Splitting dependencies into regular and development dependencies is a good practice. It makes your project cleaner and ensures that production environments only install the packages needed for the application to run, without including development tools or libraries. Howewer, here there a very few dependencies that we would not want to install in remote environment. So, it does not worth it.
5 changes: 5 additions & 0 deletions doc/XX_local_install.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@
#### Useful tasks

- TS interface generation: `cd front; npm run schemas`


#### Run Celery/beat worker

- Use VS Code command `Run task` and then chose `Celery`.
2 changes: 1 addition & 1 deletion docker-compose.remote.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ services:
# pgAdmin service
########################################################################################
pgadmin:
image: "dpage/pgadmin4:8.13"
image: "dpage/pgadmin4:8.14"
volumes:
- pgadmin-data:/var/lib/pgadmin
healthcheck:
Expand Down

0 comments on commit 14fd46a

Please sign in to comment.