Json result format

[javaguirre]

This is related to #10

The format is good now, but the syntax highlighting is a bit trickier if trying to use Atom internal system, although I almost have It. I am using the grammar tokenizer for highlighting, but I am trying to get a method from Atom API to pass the tokens to html, It doesn't seem is there anymore, or I need to read more code. Now I have:

grammar = atom.grammars.grammarForScopeName('source.json')
tokenizedLines = grammar.tokenizeLines(@processResult(body), undefined, 4))

I'll continue working on It.

I also refactored some constants, and I think all the json related code should go in a different file, I'll get into that.

[ddavison]

👍

[javaguirre]

Found a couple of bugs, missing quotes, the other was already there, and It's related to the load of the package and initalization, both fixed.

I am adding tests for the features I added, we could use that as our starting base for testing the rest of the package.

[javaguirre]

Added some specs to test the new json result process. Related to #22

[javaguirre]

I added the travis-ci config too, It worked well! 🎉

[ddavison]

you can go ahead and merge this if it's finished :)

i'll also see what i can do about allowing you to do apm publish's as well

[javaguirre]

Great, I'll do It.

Thank you!
On Nov 4, 2015 19:10, "Dj" notifications@github.com wrote:

you can go ahead and merge this if it's finished :)

i'll also see what i can do about allowing you to do apm publish's as well

—
Reply to this email directly or view it on GitHub
#23 (comment).