Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contain images that don't match a 9/16 aspect-ratio with object-fit #13

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Contain images that don't match a 9/16 aspect-ratio with object-fit #13

merged 1 commit into from
Aug 8, 2023

Conversation

JamesIves
Copy link
Contributor

@JamesIves JamesIves commented Aug 8, 2023

Currently, if an image does not fit a 9/16 aspect ratio they appear stretched:

Screenshot 2023-08-07 at 10 40 41 PM

Other platforms which have stories contain the asset, causing black bars above and below the image so the assets don't appear warped. With this change, assets that are not 9/16 will look more reasonable.

Screenshot 2023-08-07 at 10 37 13 PM

This change has no effect on existing users who already comply with the 9/16 guidelines (example below on @muan's page)

Screenshot 2023-08-07 at 10 42 17 PM

@JamesIves JamesIves changed the title Contain images with object-fit Contain images that don't match a 9/16 aspect-ratio with object-fit Aug 8, 2023
@muan muan self-requested a review August 8, 2023 02:48
Copy link
Member

@muan muan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you.

@muan muan merged commit 6a95f97 into dddddddddzzzz:main Aug 8, 2023
@muan
Copy link
Member

muan commented Aug 8, 2023

Published with 0.0.24!
Would love to have your use case over at dddddddddzzzz/OpenStories#9!

@JamesIves
Copy link
Contributor Author

Thanks! Will post it once I'm done 😊

@JamesIves JamesIves deleted the main-1 branch August 8, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants