Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show lyrics when no lyric is matched. #32

Closed
kikandychan opened this issue Apr 30, 2017 · 1 comment
Closed

do not show lyrics when no lyric is matched. #32

kikandychan opened this issue Apr 30, 2017 · 1 comment

Comments

@kikandychan
Copy link

Some songs or melodies don't have lyrics or lyrics are not matched.
When this happened, it is better to offer an option to hide the lyrics.
@ddddxxx
Copy link
Owner

ddddxxx commented Apr 30, 2017

the same as #24

ddddxxx added a commit that referenced this issue May 16, 2017
@ddddxxx
Merge branch 'dev'
23d88f7 
* dev:
  update: README
  customizable desktop lyrics position, half part of #37
  fix: storyboard calls viewDidLoad before register user default
  update: ui
  separate enabling and value of inset
  use inset instead of heigh from dock
  static animation timing function
  localization
  style: no code change
  license...
  feat: mark wrong lyrics and never search again, close #24, close #32
  remove class `UpdateManager`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddddxxx @kikandychan