Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

有些国外歌手无法搜索到歌词 #45

Closed
Arrow-Li opened this issue May 7, 2017 · 6 comments
Closed

有些国外歌手无法搜索到歌词 #45

Arrow-Li opened this issue May 7, 2017 · 6 comments

Comments

@Arrow-Li
Copy link

Arrow-Li commented May 7, 2017

像Ed Sheeran的歌就不行(翻译成艾德·希兰)，但是Adele(翻译成阿黛尔)的歌就可以正常搜索到。
同时在菜单栏点击搜索歌词会崩溃
crash.txt
@Arrow-Li
Copy link
Author

Arrow-Li commented May 7, 2017

Ed Sheeran的Dive实际上搜索到的是他的I See Fire
123

@ddddxxx
Copy link
Owner

ddddxxx commented May 7, 2017

见 #29 ，搜索结果完全取决于歌词源，是程序无法控制的。相关的讨论还有 #20

@Arrow-Li
Copy link
Author

Arrow-Li commented May 7, 2017

手动搜索会程序崩溃，见crash.txt

@ddddxxx
Copy link
Owner

ddddxxx commented May 7, 2017 •
edited
Loading

程序崩溃是每次必然发生还是随机发生，重启程序能否解决？

@Arrow-Li
Copy link
Author

Arrow-Li commented May 7, 2017

必然，无论什么歌点搜索歌词都会崩溃

@ddddxxx
Copy link
Owner

ddddxxx commented May 7, 2017

已确认，将在下一个版本修复

@ddddxxx ddddxxx closed this as completed in 00d081e May 9, 2017
ddddxxx added a commit that referenced this issue May 9, 2017
@ddddxxx
Merge branch 'dev'
2cca675 
* dev:
  migrate to GenericID
  fix: save lyrics to default path when bookmark data is stale
  fix: weak references to `NSTextView `, fix #45
  performance improvement, close #44
  fix: last commit
  fix: sandbox violation, fix #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddddxxx @Arrow-Li