Skip to content

Commit

Permalink
Fix #ddev-generated problems with HEAD, fixes #12 (#13)
Browse files Browse the repository at this point in the history
* Fix #ddev-generated problems with HEAD, fixes #12

* Explicit add of commands/web/browsersync
  • Loading branch information
rfay committed Jun 16, 2022
1 parent 5594022 commit 5946539
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: tests
on:
pull_request:
push:
branches: [ master, main ]
branches: [ main ]

schedule:
- cron: '01 07 * * *'
Expand All @@ -29,8 +29,8 @@ jobs:

strategy:
matrix:
ddev_version: [stable, edge, HEAD]
# ddev_version: [PR]
ddev_version: [stable, HEAD]
# ddev_version: [stable, edge, HEAD, PR]
fail-fast: false

runs-on: ubuntu-20.04
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ddev restart
ddev browsersync
```

The new `ddev browsersync` global command runs browsersync inside the web container and provides a
The new `ddev browsersync` global command runs browsersync inside the web container and provides a
link ("External") to the browsersync-update URL. Use the URL in the output that says something like "External: http://d9.ddev.site:3000".

## What does this add-on do and add?
Expand Down
1 change: 1 addition & 0 deletions docker-compose.browsersync.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#ddev-generated
# Override the web container's standard HTTP_EXPOSE and HTTPS_EXPOSE
# This is to expose the browsersync port.
version: '3.6'
Expand Down
5 changes: 3 additions & 2 deletions install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,19 @@ name: ddev-browsersync

pre_install_actions:
- |
#ddev-nodisplay
if ! ( ddev debug capabilities 2>/dev/null | grep multiple-dockerfiles >/dev/null 2>&1 ) ; then
echo "This add-on requires DDEV v1.19.3 or higher, please upgrade." && exit 2
fi
project_files:
- docker-compose.browsersync.yaml
- web-build
- web-build/Dockerfile.ddev-browsersync
- browser-sync.js


global_files:
- commands
- commands/web/browsersync


post_install_actions:
Expand Down

0 comments on commit 5946539

Please sign in to comment.