https-support PR: Make it report the right URL, improve tests #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed.
What a great idea to replace the browsersync output with our own. We lose console refresh updates although that seems a fair trade off. |
tyler36
added a commit
that referenced
this pull request
Nov 30, 2022
* browsersync should default to HTTPS * update test to verify HTTPS * additional notes about HTTPS in readme * replace test comment * https-support PR: Make it report the right URL, improve tests (#31) * Improve output of ddev browsersync to show https URL * Update tests and github setup to make work with https * Do mkcert -install so we can trust certs Co-authored-by: tyler36 <7234392+tyler36@users.noreply.github.com> Co-authored-by: Randy Fay <randy@randyfay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.