-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command runs "per-project" #42
command runs "per-project" #42
Conversation
b7b0b30
to
a49d40d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Project also overrides global, so shouldn't matter that we've left an orphaned one. But... I wonder if it would be worth trying to delete the global one in post_install? That also seems intrusive.
I thought about that. Most people wont even notice the change if/when they update. We could add a line to the README or maybe to the output on install? |
Agreed - would be outstanding (and far better) to tell them what they can delete and why. For extra credit, test to see if it exists and if it does tell them to delete it. |
Added first draft of note. I suspect @mattstein could improve on it. |
I don't see the first draft @tyler36 |
Pushed to correct branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestions for paring this down a little! First time I’ve looked at this readme and I may need to follow on with a PR that fixes a bunch of product names and smaller nitpicks that were well out of scope here.
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Matt Stein <m@ttste.in>
@mattstein Thank you! |
This PR moves the
browsersync
command to a "per-project" level.The command should not be available if the project doesn't support ddev-browsersync.