Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 11 is the main stable branch #88

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

claudiu-cristea
Copy link
Contributor

The Issue

Drupal 11 is the main stable branch. This already happens in Drupal GitLab CI, see https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/242

How This PR Solves The Issue

Installs by default with Drupal 11.

Manual Testing Instructions

On a contrib, configure DDEV with /ddev/ddev-drupal-contrib and run ddev poser. You should get a D11 site by default.

Automated Testing Overview

Should work

Related Issue Link(s)

https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/242

Release/Deployment Notes

None.

@weitzman
Copy link
Collaborator

Makes sense. We may need to adjust CI PHP version as well to fix test failures.

@claudiu-cristea
Copy link
Contributor Author

Not sure I know how to do that. I see no PHP version configured in https://github.com/ddev/ddev-drupal-contrib/blob/main/.github/workflows/tests.yml

@hanoii
Copy link
Contributor

hanoii commented Oct 23, 2024

@claudiu-cristea if you are OK giving me access to your fork, I can push a fix for the tests

@claudiu-cristea
Copy link
Contributor Author

@hanoii you're invited

@hanoii
Copy link
Contributor

hanoii commented Oct 24, 2024

updated main, rebased and push a fix for tests

@weitzman
Copy link
Collaborator

Does the readme need adjusting for corepack?

@hanoii
Copy link
Contributor

hanoii commented Oct 24, 2024

@weitzman yes, just did

@weitzman weitzman merged commit dfa4d3b into ddev:main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants