fix: remove ProjectTypes from phpstan command #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In DDEV v1.24.0 (HEAD) the
drupal111project type becomes "normal" for D11, and is autodetected in ddev-drupal-contrib tests.The phpstan command provided by this add-on had a
# ProjectTypes: drupal,drupal8,drupal9,drupal10which isn't very useful. (That directive is intended to not clog up theddev helpwhen using project types other than Drupal*)Current tests using DDEV HEAD are failing with "# Command 'phpstan' is not available for the 'drupal11' project type."
How This PR Solves The Issue
Remove the ProjectTypes restriction on this one command. As with the rest of the commands in this add-on, it seems people would not have installed this add-on if they weren't using Drupal.
Manual Testing Instructions
Install add-on
Restart
ddev phpstanAutomated Testing Overview
Related Issue Link(s)
Release/Deployment Notes