Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set project workspace in Gitpod VScode #39

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Jun 24, 2024

The Issue

Currently, ddev-gitpod-launch opens Gitpod with "/workspace/ddev-gitpod-launcher" set as the workspace root when using Gitpod VScode.

As a developer, I want the DDEV project as my workspace root.

How This PR Solves The Issue

This PR:

  • creates a /workspace/code directory
  • clones the target repo into /workspace/code
  • defines /workspace/code as the workspace root
  • removes some obsolete code

Manual Testing Instructions

  • Follow instructions on main page to launch Gitpod session
  • Once complete, VSCode Explorer panel should display the "code" folder with the target repo.

Automated Testing Overview

Related Issue Link(s)

Fixes #3

Release/Deployment Notes

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the overall best thing here is to check out the project into its own place in /workspace instead of checking it out into a subdirectory of ddev-gitpod-launcher. Do you think there's a way to do that?

DDEV's gitpod.yml does that for PR and core workflows, but those may be a bit different from here.

@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 25, 2024

IMO the overall best thing here is to check out the project into its own place in /workspace instead of checking it out into a subdirectory of ddev-gitpod-launcher. Do you think there's a way to do that?

Thats exactly what this PR does. Is it not working as expected?

Oh, I see. The manual steps in the description are wrong.

Manual testing

@rfay
Copy link
Member

rfay commented Jun 25, 2024

In that case it has nothing to do with vscode does it? I guess that's what confused me. You're doing a good thing for everything and everybody?

@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 25, 2024

In that case it has nothing to do with vscode does it? I guess that's what confused me. You're doing a good thing for everything and everybody?

Now I am confused. 😄

This PR address an issue from #3 (ddev-gitpod-launcher and selecting VScode as the IDE) specificly the explorer panel.
Using d9simple as an example for ddev-gitpod-launcher:

@rfay
Copy link
Member

rfay commented Jun 25, 2024

IMO it fixes much more than that :) because it fixes the confusion people have by it being in a subdirectory.

@rfay
Copy link
Member

rfay commented Jun 25, 2024

Sorry I didn't get back to this today, looking forward to testing it. Great leap forward!

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a wonderful and appreciated improvement. I've been wanting this for a long time. It will really help people. Thanks!

Go ahead and pull it whenever you are ready.

.gitpod/start_repo.sh Outdated Show resolved Hide resolved
@tyler36 tyler36 mentioned this pull request Jun 28, 2024
@tyler36 tyler36 merged commit bc688e0 into ddev:main Jun 28, 2024
@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 28, 2024

What a great win!

@tyler36 tyler36 deleted the 12-Move-checked-out-code-into-its-own-directory-point-workspace-location branch June 28, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants