-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set project workspace in Gitpod VScode #39
fix: set project workspace in Gitpod VScode #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the overall best thing here is to check out the project into its own place in /workspace instead of checking it out into a subdirectory of ddev-gitpod-launcher. Do you think there's a way to do that?
DDEV's gitpod.yml does that for PR and core workflows, but those may be a bit different from here.
Thats exactly what this PR does. Is it not working as expected? Oh, I see. The manual steps in the description are wrong. Manual testing
|
In that case it has nothing to do with vscode does it? I guess that's what confused me. You're doing a good thing for everything and everybody? |
Now I am confused. 😄 This PR address an issue from #3 (ddev-gitpod-launcher and selecting VScode as the IDE) specificly the explorer panel. |
IMO it fixes much more than that :) because it fixes the confusion people have by it being in a subdirectory. |
Sorry I didn't get back to this today, looking forward to testing it. Great leap forward! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a wonderful and appreciated improvement. I've been wanting this for a long time. It will really help people. Thanks!
Go ahead and pull it whenever you are ready.
What a great win! |
The Issue
Currently, ddev-gitpod-launch opens Gitpod with "/workspace/ddev-gitpod-launcher" set as the workspace root when using Gitpod VScode.
As a developer, I want the DDEV project as my workspace root.
How This PR Solves The Issue
This PR:
/workspace/code
directory/workspace/code
/workspace/code
as the workspace rootManual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Fixes #3
Release/Deployment Notes