-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gitpod ports #42
base: main
Are you sure you want to change the base?
Conversation
Haven't had a chance to test it yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for chasing this!
The actual source of the problem is in DDEV, and apparently it's been there since before the mailpit change. See
OK. Not sure what changes you would like here though. |
There is no way to change it here, as it needs to be changed in DDEV. But I'm not sure why it needs to be changed. Is it |
Consistency, mostly. EG. Xdebug port:
|
Xdebug has been on 9003 for several years, since before gitpod support. I'm wondering how it got that? If you can live with mailpit listening on 8027, it's OK there. People shouldn't have to know where these ports are. |
Sorry, I got confused between your two PRs |
The Issue
I was debugging Mailpit issues in Gitpod when I noticed many of the ports are outdated.
How This PR Solves The Issue
This PR
https://github.com/ddev/ddev/blob/master/.gitpod.yml
This PR does NOT update the Mailpit port. See #40
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes