Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitpod ports #42

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Jun 24, 2024

The Issue

I was debugging Mailpit issues in Gitpod when I noticed many of the ports are outdated.

How This PR Solves The Issue

This PR

This PR does NOT update the Mailpit port. See #40

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@tyler36 tyler36 marked this pull request as ready for review June 24, 2024 08:58
@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 24, 2024

Haven't had a chance to test it yet.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for chasing this!

The actual source of the problem is in DDEV, and apparently it's been there since before the mailpit change. See

https://github.com/ddev/ddev/blob/38a31a0c5f219b9258f6a8b0dd15841d26b904c6/pkg/ddevapp/ddevapp.go#L2064-L2078

@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 24, 2024

OK. Not sure what changes you would like here though.

@rfay
Copy link
Member

rfay commented Jun 24, 2024

There is no way to change it here, as it needs to be changed in DDEV.

But I'm not sure why it needs to be changed. Is it ddev mailpit that needs to be changed? What is the goal?

@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 25, 2024

Consistency, mostly.

EG. Xdebug port:

  • FIle lists 9000 as xdebug port, but xdebug is on 9003. So this is confusing.
  • If it doesn't matter (ie, we don't use it), lets delete the entry so there's less maintainance.

@rfay
Copy link
Member

rfay commented Jun 25, 2024

Xdebug has been on 9003 for several years, since before gitpod support. I'm wondering how it got that?

If you can live with mailpit listening on 8027, it's OK there. People shouldn't have to know where these ports are.

@rfay
Copy link
Member

rfay commented Jun 25, 2024

Sorry, I got confused between your two PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants