Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VNC connection without password by default #50

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

MurzNN
Copy link
Contributor

@MurzNN MurzNN commented Jul 24, 2024

The Issue

Now we have to type the secret password each time when connecting. But ddev usually runs locally on local machines, so there is no sense in protecting it by password, especially with the well-known one.

Also, it pretty often gets stuck, so I have to restart the container many times per day, and then - reconnect noVNC again with typing the password.

So, I vote for making the VNC connection without a password by default.

How This PR Solves The Issue

Allows connection without any password by default.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

VNC connection does not require the secret password and connects automatically without any password.

@weitzman
Copy link
Collaborator

Seems reasonable to me. Any objection, @rfay?

@rfay
Copy link
Member

rfay commented Jul 24, 2024

I certainly don't object to default password. It's what we do everywhere, like database, etc.

@weitzman
Copy link
Collaborator

The proposal in this PR is to remove the default password, and have no password.

@rfay
Copy link
Member

rfay commented Jul 24, 2024

Yeah, I didn't state that clearly. I don't see a reason to have a password. The reason it's the same as DDEV's strategy is that although the db, for example, has a password, it's always db and generally preconfigured.

@weitzman weitzman merged commit 043f5a9 into ddev:main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants