Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper commands #16

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

tyler36
Copy link
Contributor

@tyler36 tyler36 commented Jan 25, 2023

This PR adds helper commands for interacting with Varnish.

All commands are designed to:

  • run in the Varnish container
  • pass through additional parameters from original command.

Commands were sourced from https://varnish-cache.org/docs/6.5/reference/index.html .

@rfay
Copy link
Member

rfay commented Jan 25, 2023

Please also add info about these commands to the README.md, thanks!

@tyler36
Copy link
Contributor Author

tyler36 commented Jan 26, 2023

  • Documentation was added for main readme
  • Updated the "Usage" section of each commands

@rfay
Copy link
Member

rfay commented Feb 1, 2023

@jedubois what do you think of this? Are you getting notifications from this repo?

@jedubois
Copy link
Collaborator

jedubois commented Feb 2, 2023

@rfay , looks like a useful addition. @tyler36 , any reason not to include varnishadm?

@jedubois jedubois merged commit af8f7c8 into ddev:main Feb 2, 2023
@jedubois
Copy link
Collaborator

jedubois commented Feb 2, 2023

@jedubois what do you think of this? Are you getting notifications from this repo?

@rfay , getting notifications but not getting around to following up. Merged this but want to hold off on another release to see about adding varnishadm, think possibly another command some coworkers often use (a simplified cache clear for non-Varnish experts), and look at updating doc reference to 6.0LTS which is base version I think this add-on should stick to.

@rfay
Copy link
Member

rfay commented Feb 2, 2023

Thanks @jedubois totally understand you have other things to do, and very much appreciate you maintaining this. It makes so much sense for a real user to maintain things.

@rfay
Copy link
Member

rfay commented Feb 2, 2023

BTW, this will be moving to github.com/ddev/ddev-varnish shortly, shouldn't impact anything at all.

@tyler36
Copy link
Contributor Author

tyler36 commented Feb 3, 2023

any reason not to include varnishadm?

@jedubois no reason, think I just missed when adding the others.

@tyler36 tyler36 deleted the tyler36/helper_commands branch February 3, 2023 00:19
@tyler36 tyler36 mentioned this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants