Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official ddev-mongo addon #16

Closed
wants to merge 2 commits into from
Closed

Use official ddev-mongo addon #16

wants to merge 2 commits into from

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Nov 10, 2023

This PR attempts to use the DDEV's mongo addon.

Fixes #13

Notes

Currently, we use "percona/percona-server-mongodb:6.0-multi" for arm64 compatibility (00c1cca).

@tyler36 tyler36 changed the title Use official ddev-mongo Use official ddev-mongo addon Nov 10, 2023
rfay
rfay reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to change the README to install ddev-mongo before installing ddev-xhgui

@tyler36 tyler36 mentioned this pull request Nov 16, 2023
Closed
@rfay
Copy link
Member

rfay commented Nov 16, 2023

Test with ddev get https://github.com/tyler36/ddev-xhgui/tarball/13-Investigate-using-official-mongo-addon-for-database

@tyler36
Copy link
Collaborator Author

tyler36 commented Nov 16, 2023

Fixes #20

@tyler36 tyler36 force-pushed the 13-Investigate-using-official-mongo-addon-for-database branch from b3059e2 to dfc2a8e Compare November 21, 2023 02:38
@tyler36 tyler36 mentioned this pull request Nov 21, 2023
Merged
@tyler36 tyler36 force-pushed the 13-Investigate-using-official-mongo-addon-for-database branch from dfc2a8e to 419c0e9 Compare November 28, 2023 01:20
@tyler36
Copy link
Collaborator Author

tyler36 commented Nov 28, 2023

Added ddev-mongo to "Getting Started"

@rfay
Copy link
Member

rfay commented May 28, 2024

This is obsolete now right?

@tyler36
Copy link
Collaborator Author

tyler36 commented May 28, 2024

Yes. This was an early solution to fix #14

I was aiming to get #22 in though but ... "time".

Closing in favor of #22

@tyler36 tyler36 closed this May 28, 2024
@tyler36 tyler36 mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate using official mongo addon for database.
2 participants
@tyler36 @rfay