Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add-on work w/o ddev-router, update tests #37

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

stasadev
Copy link
Member

The Issue

This add-on doesn't work in Gitpod.

How This PR Solves The Issue

In terms of functionality, this add-on is similar to https://github.com/ddev/ddev-phpmyadmin
This PR contains recent fixes and improvements from ddev-phpmyadmin.

Manual Testing Instructions

Test it locally and in Gitpod.

Open in Gitpod

ddev get https://github.com/ddev/ddev-xhgui/tarball/20240718_stasadev_norouter
ddev restart
ddev xhgui

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay
Copy link
Member

rfay commented Jul 18, 2024

For more generality we may want to move to using the router on gitpod/codespaces.

@tyler36
Copy link
Collaborator

tyler36 commented Jul 19, 2024

Hmmm ... not sure if If like the restart in the health checks. I know it removes duplication, but personally, I prefer it in the test body. That way:

  • it reminds me I need to restart after the install,
  • keeps the health checks clean; the check do just that, check, and
  • it doesn't force a restart if I need to run health checks multiple times in the same test.

If you prefer it in the health check, I guess I'm OK with that.

@stasadev
Copy link
Member Author

If you prefer it in the health check, I guess I'm OK with that.

It was a simple copy-paste to match the code in ddev-phpmyadmin.

I like your arguments, so I reverted this change.

@tyler36
Copy link
Collaborator

tyler36 commented Jul 22, 2024

Works great! Thank you.

Test

  1. Click "Open in GItpod" link in description.

  2. Add PR via tarball.

    ddev get https://github.com/ddev/ddev-xhgui/tarball/20240718_stasadev_norouter
  3. Restart DDEV to apply addon.

    ddev restart
  4. Confirm site is working.

    ddev launch
  5. Configure Drupal umami following instructions in this repo's README.

  6. Start profiling.

    ddev xhprof
  7. Navigate site to generate a couple of profile reports.

  8. Confirm launch command opens xhgui.

    ddev xhgui

image

@tyler36 tyler36 merged commit 722b920 into main Jul 22, 2024
2 checks passed
@tyler36 tyler36 deleted the 20240718_stasadev_norouter branch July 22, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants