-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vite blog article #115
Conversation
Yay! |
Thanks, just mark it ready to review when you're ready. Looks like there are just minor textlint complaints. |
👍 will do. hope to finish it by the end of next week, maybe a week later. cheers! |
Hey @rfay, I completed the article draft, hope it will be useful for the community. Questions:
Happy to adjust it / make changes after review of course. Cheers! 👋 |
Yay, thanks! Can you suggest any good reviewers? Will ask @tyler36 - could you take a look? |
An we also need to add the type property: | ||
|
||
```json | ||
type: "module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs quotes (and comma) to be valid.
type: "module" | |
"type": "module", |
Went through the example, and was able to to follow along and get it working. I didn't try any of the framework guides. |
And, of course, thank you for taking the time to write up the article. I know questions often come up on Discord about vite and DDEV and it's great to have a well-written and easy to follow guide to recommend to others. Thank you @mandrasch ! |
Nice, thanks so much for review! 👍 👍 I'll fix the typo with module later on.
Good point / question. 👍 Also thought about it. Personally I don't use viteserve because I want to run vite visible - and want to see my errors directly if a JS file has an error for example in the vite output. Therefore I just use Most JS frameworks like sveltekit, nextjs, etc. work like that as far as I experience it: You run The aspect of log output is adressed here torenware/ddev-viteserve#20 I have much respect for torenwares hard work on this, but personally I don't want to complicate the introduction. Maybe we could add a vite section on https://github.com/ddev/awesome-ddev, add available add-ons there and link to it? (Or somebody creates another article about viteserve) Btw: Just thought about that maybe this current article could also be split in two parts 🤔 :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! It's going to be great.
What do you think about using the photo of you as the main image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
I rebased and also made a number of small suggestions, you should be able to just accept the ones you're OK with by using the GitHub web interface.
@mattstein doesn't allow me to use the word "simply". There should be an exception for you, but there's not :) |
Thanks for the graphic! |
Sure thing. 👍 (I used https://www.adobe.com/express/feature/image/remove-background and a canva template https://www.canva.com/templates/?query=youtube-thumbnail) |
@rfay thanks for review / fixes. from my point of view we're good to go. 👍 if you have further feedback, just let me know :) |
Thanks so much! |
The Issue
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes
Status