-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GHC 8.4, and LTS 11.2 #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks great.
Unfortunately it is not backwards compatible due to change in
TemplateHaskell.
I also added one more change down the line to make sure it correctly
executes example code on Mac OS X.
…On Mon, Jul 30, 2018 at 11:52 PM David Fisher ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for the PR! Looks great.
------------------------------
In HaPy-haskell/Foreign/HaPy.hs
<#8 (comment)>:
> @@ -90,7 +90,7 @@ toForeignExp _ exp = fail "conversion failed: unknown type!"
makeFunction :: (String -> String) -> (Name -> [FType] -> ClauseQ) -> ([FType] -> TypeQ) -> Name -> DecsQ
makeFunction changeName makeClause makeType origName = do
- VarI _ t _ _ <- reify origName
+ VarI _ t _ <- reify origName
Is this change backwards-compatible? If not, we should bump the major
version number.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAp12bhq1JzK_D0I7vPwu1HrIsRD-b_pks5uL4AcgaJpZM4VmqO0>
.
|
Sorry for not having gotten to this so far! I should have time to to finish the review and release the new version in the next couple days. |
Wow! Great to see that you are still interested in this.
It seems quite tempting as an approach that can last over several compiler
versions and allow multitudes of HaskelloPythonists to use common API.
--
Cheers
Michał
…On Tue, Oct 2, 2018 at 12:24 AM David Fisher ***@***.***> wrote:
Sorry for not having gotten to this so far! I should have time to to
finish the review and release the new version in the next couple days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAp12a-BTfJWalIa__Ms-7ybmdXZ__qPks5ugpYMgaJpZM4VmqO0>
.
|
so close! |
Could use this update! |
@ddfisher Can you please add me as maintainer? |
No description provided.