Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude default ports 80/443 from base URL #68

Closed
wants to merge 4 commits into from

Conversation

dinoboff
Copy link
Contributor

@dinoboff dinoboff commented Dec 21, 2017

Fix #59.

E2E tests require secrets and tokens to be set. Skip those tests when
the environment variables are missing.
@dinoboff
Copy link
Contributor Author

dinoboff commented Dec 21, 2017

#getBaseUrl could use URL to parse the url, remove the search component and encode it again (URL by default remove the default ports).

We could import URL from whatwg-url and build a UMD version that expect global.URL.

@ddo would it be ok to use URL, to import whatwg-url on node and build the the browser version without the import (using window.URL) using something like rollup?

@dinoboff dinoboff changed the title [WIP] Exclude default ports 80/443 from base URL Exclude default ports 80/443 from base URL Dec 22, 2017
@dinoboff
Copy link
Contributor Author

dinoboff commented Dec 22, 2017

Actually it doesn't need a build process. With just one dep. and one file, it's no issue to manage the umd header manually.

@dinoboff
Copy link
Contributor Author

dinoboff commented Dec 22, 2017

Maybe URL is not suitable since it will normalise other components like unicode hostname.

To use URL, OAuth could throw if the provided URL is ambiguous.

@dinoboff dinoboff closed this Dec 23, 2017
@dinoboff
Copy link
Contributor Author

closing: oauth-1.0a will need an other url parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant