-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename usage of Dir/File.exists to exist #788
Conversation
The singular methods were deprecated long ago and finally removed in Ruby 3.2.0.
Looking forward to having this merged. We are seeing these deprecations after upgrading to Ruby 3.1.3. |
Ruby 3.2 removes Dir.exists? and File.exists? but that will not yet be discovered via tests since FakeFS is used and it creates its own aliases.I have a PR open to update that FakeFS: fakefs/fakefs#482 Also, updating the workflow to test 3.2 would be kind. |
Thanks for your efforts @ecnelises . We need this too. |
Thanks @ecnelises for this work! @ddollar hey 👋 Thanks in advanced! |
just run up against this issue. manual edit of base.rb fixed it locally but next time I update... |
Any update concerning potential merge ? |
There is another |
Already fixed by c944101 |
This just fixes the spec, it is still broken in ruby 3.2 |
Thank you! |
Yay! Thank you so much @ddollar! |
The singular methods were deprecated long ago and finally removed in Ruby 3.2.0.
See ruby/ruby@bf97415