Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

refactor(types): improve type definitions #623

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

nogic1008
Copy link
Contributor

No description provided.

@commit-lint
Copy link

commit-lint bot commented Sep 7, 2022

Code Refactoring

  • composable: remove isLoading (bb697d9)
  • content: change type definitions (a16b6b8)

Tests

Contributors

nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #623 (219bbc2) into master (7036927) will increase coverage by 0.00%.
The diff coverage is 80.76%.

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   97.27%   97.28%           
=======================================
  Files          18       18           
  Lines         624      625    +1     
  Branches       76       76           
=======================================
+ Hits          607      608    +1     
  Misses         17       17           
Impacted Files Coverage Δ
components/SearchBox.vue 93.10% <60.00%> (-0.23%) ⬇️
components/content/SongList.vue 95.78% <66.66%> (ø)
pages/songs/[id].vue 96.52% <66.66%> (ø)
pages/songs/index.vue 94.68% <75.00%> (ø)
composables/useSoftwareData.ts 100.00% <100.00%> (ø)
composables/useSoftwareList.ts 100.00% <100.00%> (ø)
pages/index.vue 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nogic1008 nogic1008 added development:rocket: Area development (testing, deploy...) refactoring:sparkles: Not a new feature (code clean, remove dup...) labels Sep 7, 2022 — with GitHub Codespaces
@nogic1008 nogic1008 added this to the v0.8.0 milestone Sep 7, 2022
@nogic1008 nogic1008 merged commit 109bec8 into master Sep 7, 2022
@nogic1008 nogic1008 deleted the refactor/composables branch September 7, 2022 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
development:rocket: Area development (testing, deploy...) refactoring:sparkles: Not a new feature (code clean, remove dup...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant