Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

refactor: use @vue/test-utils flushPromises & refactor type definitions #740

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

nogic1008
Copy link
Contributor

No description provided.

@nogic1008 nogic1008 added development:rocket: Area development (testing, deploy...) refactoring:sparkles: Not a new feature (code clean, remove dup...) labels Feb 7, 2023
@nogic1008 nogic1008 added this to the v1.0 milestone Feb 7, 2023
@commit-lint
Copy link

commit-lint bot commented Feb 7, 2023

Code Refactoring

  • test: use @vue/test-utils flushPromises (746e888)
  • reduce any uses (04cb5ec)
  • move type definition (4723e1a)

Contributors

nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #740 (4723e1a) into master (af13b2c) will decrease coverage by 1.31%.
The diff coverage is 76.00%.

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   92.62%   91.32%   -1.31%     
==========================================
  Files          20       19       -1     
  Lines         434      438       +4     
  Branches       32       32              
==========================================
- Hits          402      400       -2     
- Misses         32       38       +6     
Impacted Files Coverage Δ
composables/useSoftwareList.ts 31.81% <22.22%> (-9.36%) ⬇️
composables/useSongData.ts 66.66% <81.81%> (+16.66%) ⬆️
composables/useSongList.ts 57.14% <83.33%> (+11.68%) ⬆️
composables/useSoftwareData.ts 72.72% <90.47%> (+22.72%) ⬆️
components/content/Charts.vue 100.00% <100.00%> (ø)
components/content/SeriesList.vue 100.00% <100.00%> (ø)
pages/songs/index.vue 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nogic1008 nogic1008 merged commit fa090b4 into master Feb 7, 2023
@nogic1008 nogic1008 deleted the refactor/test-promise branch February 7, 2023 04:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
development:rocket: Area development (testing, deploy...) refactoring:sparkles: Not a new feature (code clean, remove dup...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant