build: add more lint rules (#176)

* refactor: shorthand typescript config * build(lint): add lint plugin * refactor: lint all files * build: add npm-run-all package * chore: add parallel script * chore: move eslint plugin to dev * test: add snapshot tests * refactor: prettier master json
ddradar · Feb 17, 2020 · f6e0c9f · f6e0c9f
1 parent 0885ec1
commit f6e0c9f
Show file tree

Hide file tree

Showing 58 changed files with 7,396 additions and 224 deletions.
diff --git a/.codecov.yml b/.codecov.yml
@@ -6,7 +6,7 @@ codecov:
 coverage:
   precision: 2
   round: down
-  range: "70...100"
+  range: '70...100'
 
   status:
     project:
@@ -24,7 +24,7 @@ parsers:
       macro: no
 
 comment: # See: https://docs.codecov.io/docs/pull-request-comments
-  layout: "reach, diff, flags, files"
+  layout: 'reach, diff, flags, files'
   behavior: default
   require_changes: no
   require_base: yes

diff --git a/.dependabot/config.yml b/.dependabot/config.yml
@@ -1,17 +1,17 @@
 version: 1
 update_configs:
-  - package_manager: "javascript"
-    directory: "/"
-    update_schedule: "live"
+  - package_manager: 'javascript'
+    directory: '/'
+    update_schedule: 'live'
     default_reviewers:
-      - "nogic1008"
+      - 'nogic1008'
     default_labels:
-      - "dependabot:robot:"
+      - 'dependabot:robot:'
     commit_message:
-      prefix: "fix"
-      prefix_development: "chore"
+      prefix: 'fix'
+      prefix_development: 'chore'
       include_scope: true
     automerged_updates:
       - match:
-          dependency_type: "all"
-          update_type: "security:patch"
+          dependency_type: 'all'
+          update_type: 'security:patch'
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -2,7 +2,8 @@
   "root": true,
   "env": {
     "browser": true,
-    "node": true
+    "node": true,
+    "jest": true
   },
   "extends": [
     "@nuxtjs/eslint-config-typescript",
@@ -11,9 +12,12 @@
     "plugin:prettier/recommended",
     "plugin:nuxt/recommended"
   ],
-  "plugins": ["prettier"],
+  "plugins": ["jest", "prettier", "simple-import-sort"],
   "rules": {
+    "import/order": "off",
     "no-process-env": "error",
-    "no-useless-constructor": "off"
+    "no-useless-constructor": "off",
+    "simple-import-sort/sort": "error",
+    "sort-imports": "off"
   }
 }
diff --git a/.github/workflows/import-song.yml b/.github/workflows/import-song.yml
@@ -13,36 +13,36 @@ jobs:
       CI: true
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v1
-    - name: Use Node.js 12
-      uses: actions/setup-node@v1
-      with:
-        node-version: 12
-    - name: Use Cache # for optimize Install Dependencies
-      uses: actions/cache@v1
-      with:
-        path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-    - name: npm install
-      run: npm ci
-    - name: Unit Test with Jest
-      run: npm test
-    - name: Import Data to Firebase
-      run: npm start
-      env:
-        FIREBASE_CLIENT_EMAIL: ${{ secrets.FIREBASE_CLIENT_EMAIL }}
-        FIREBASE_PRIVATE_KEY: ${{ secrets.FIREBASE_PRIVATE_KEY }}
-        FIREBASE_PROJECT_ID: ${{ secrets.FIREBASE_SDK_PROJECT_ID }}
-    - name: Prettier Created Json
-      run: npx prettier -l "./static/*.json" --write
-    - name: Push Created Json Files
-      run: |
-        git config --local user.email "${GITHUB_ACTOR}@users.noreply.github.com"
-        git config --local user.name ${GITHUB_ACTOR}
-        git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${GITHUB_REPOSITORY}.git
-        git checkout master
-        git add -A
-        git commit -m "feat(song): update master json from ${GITHUB_SHA}"
-        git push
+      - uses: actions/checkout@v1
+      - name: Use Node.js 12
+        uses: actions/setup-node@v1
+        with:
+          node-version: 12
+      - name: Use Cache # for optimize Install Dependencies
+        uses: actions/cache@v1
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - name: npm install
+        run: npm ci
+      - name: Unit Test with Jest
+        run: npm test
+      - name: Import Data to Firebase
+        run: npm start
+        env:
+          FIREBASE_CLIENT_EMAIL: ${{ secrets.FIREBASE_CLIENT_EMAIL }}
+          FIREBASE_PRIVATE_KEY: ${{ secrets.FIREBASE_PRIVATE_KEY }}
+          FIREBASE_PROJECT_ID: ${{ secrets.FIREBASE_SDK_PROJECT_ID }}
+      - name: Prettier Created Json
+        run: npx prettier -l "./static/*.json" --write
+      - name: Push Created Json Files
+        run: |
+          git config --local user.email "${GITHUB_ACTOR}@users.noreply.github.com"
+          git config --local user.name ${GITHUB_ACTOR}
+          git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${GITHUB_REPOSITORY}.git
+          git checkout master
+          git add -A
+          git commit -m "feat(song): update master json from ${GITHUB_SHA}"
+          git push
diff --git a/.github/workflows/node-cd.yml b/.github/workflows/node-cd.yml
@@ -9,54 +9,54 @@ jobs:
     name: Deploy
     runs-on: ubuntu-latest
     steps:
-    - name: Checkout
-      uses: actions/checkout@v1
-    - name: Use Node.js 12
-      uses: actions/setup-node@v1
-      with:
-        node-version: 12
-    - name: Use Cache
-      uses: actions/cache@v1
-      with:
-        path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-    - name: Install Dependencies
-      run: npm ci
-    - name: Build (Production)
-      run: npm run build
-      env:
-        FIREBASE_API_KEY: ${{ secrets.FIREBASE_SDK_API_KEY }}
-        FIREBASE_PROJECT_ID:  ${{ secrets.FIREBASE_SDK_PROJECT_ID }}
-        FIREBASE_MESSAGING_SENDER_ID:  ${{ secrets.FIREBASE_SDK_MESSAGING_SENDER_ID }}
-        FIREBASE_APP_ID:  ${{ secrets.FIREBASE_SDK_APP_ID }}
-    - name: Deploy to Firebase (Production)
-      uses: w9jds/firebase-action@v1.2.0
-      with:
-        args: deploy
-      env:
-        FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
-        PROJECT_ID: ${{ secrets.FIREBASE_SDK_PROJECT_ID }}
-    - name: Pack Artifact
-      run: zip -r dist ./dist
-    - name: Create Github Release
-      id: create_release
-      uses: actions/create-release@v1.0.0
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        tag_name: ${{ github.ref }}
-        release_name: Release ${{ github.ref }}
-        draft: false
-        prerelease: false
-    - name: Upload Release Asset
-      id: upload-release-asset
-      uses: actions/upload-release-asset@v1.0.1
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        upload_url: ${{ steps.create_release.outputs.upload_url }}
-        asset_path: ./dist.zip
-        asset_name: dist.zip
-        asset_content_type: application/zip
+      - name: Checkout
+        uses: actions/checkout@v1
+      - name: Use Node.js 12
+        uses: actions/setup-node@v1
+        with:
+          node-version: 12
+      - name: Use Cache
+        uses: actions/cache@v1
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - name: Install Dependencies
+        run: npm ci
+      - name: Build (Production)
+        run: npm run build
+        env:
+          FIREBASE_API_KEY: ${{ secrets.FIREBASE_SDK_API_KEY }}
+          FIREBASE_PROJECT_ID: ${{ secrets.FIREBASE_SDK_PROJECT_ID }}
+          FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.FIREBASE_SDK_MESSAGING_SENDER_ID }}
+          FIREBASE_APP_ID: ${{ secrets.FIREBASE_SDK_APP_ID }}
+      - name: Deploy to Firebase (Production)
+        uses: w9jds/firebase-action@v1.2.0
+        with:
+          args: deploy
+        env:
+          FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
+          PROJECT_ID: ${{ secrets.FIREBASE_SDK_PROJECT_ID }}
+      - name: Pack Artifact
+        run: zip -r dist ./dist
+      - name: Create Github Release
+        id: create_release
+        uses: actions/create-release@v1.0.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          tag_name: ${{ github.ref }}
+          release_name: Release ${{ github.ref }}
+          draft: false
+          prerelease: false
+      - name: Upload Release Asset
+        id: upload-release-asset
+        uses: actions/upload-release-asset@v1.0.1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./dist.zip
+          asset_name: dist.zip
+          asset_content_type: application/zip
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -25,56 +25,56 @@ jobs:
     env:
       CI: true
     steps:
-    - name: Checkout
-      uses: actions/checkout@v1
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - name: Setup Java 11
-      uses: actions/setup-java@v1
-      with:
-        java-version: 11
-        architecture: x64
-    - name: Use Cache # for optimize Install Dependencies
-      uses: actions/cache@v1
-      with:
-        path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-    - name: Install Dependencies
-      run: npm ci
-    - name: Install firestore Emulator
-      run: |
-        npm i -g firebase-tools
-        npx firebase setup:emulators:firestore
-    - name: Lint
-      run: npm run lint
-    - name: Build (Staging)
-      run: npm run build
-    - name: Run firestore Emulator & Test with Jest
-      run: firebase emulators:exec --only firestore "npm run test:all -- --ci"
-    - name: Report Code Coverage to codecov
-      uses: codecov/codecov-action@v1.0.5
-      with:
-        token: ${{ secrets.CODECOV_TOKEN }}
-    - name: Deploy to Firebase (Staging)
-      if: matrix.is-main && github.event_name == 'push'
-      run: |
-        firebase use --add ddradar-staging
-        firebase deploy --only firestore
-      env:
-        FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
-    - name: Deploy to GitHub Pages
-      if: matrix.is-main && github.event_name == 'push'
-      run: |
-        echo staging.ddradar.app > ./dist/CNAME
-        wget https://raw.githubusercontent.com/peaceiris/actions-gh-pages/v2/entrypoint.sh
-        bash ./entrypoint.sh
-      env:
-        PERSONAL_TOKEN: ${{ secrets.PERSONAL_TOKEN }}
-        PUBLISH_BRANCH: gh-pages
-        PUBLISH_DIR: ./dist
-        INPUT_COMMITMESSAGE: "ci: auto deployment from"
-        INPUT_EMPTYCOMMITS: false
+      - name: Checkout
+        uses: actions/checkout@v1
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Setup Java 11
+        uses: actions/setup-java@v1
+        with:
+          java-version: 11
+          architecture: x64
+      - name: Use Cache # for optimize Install Dependencies
+        uses: actions/cache@v1
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - name: Install Dependencies
+        run: npm ci
+      - name: Install firestore Emulator
+        run: |
+          npm i -g firebase-tools
+          npx firebase setup:emulators:firestore
+      - name: Lint
+        run: npm run lint
+      - name: Build (Staging)
+        run: npm run build
+      - name: Run firestore Emulator & Test with Jest
+        run: firebase emulators:exec --only firestore "npm run test:all -- --ci"
+      - name: Report Code Coverage to codecov
+        uses: codecov/codecov-action@v1.0.5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+      - name: Deploy to Firebase (Staging)
+        if: matrix.is-main && github.event_name == 'push'
+        run: |
+          firebase use --add ddradar-staging
+          firebase deploy --only firestore
+        env:
+          FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
+      - name: Deploy to GitHub Pages
+        if: matrix.is-main && github.event_name == 'push'
+        run: |
+          echo staging.ddradar.app > ./dist/CNAME
+          wget https://raw.githubusercontent.com/peaceiris/actions-gh-pages/v2/entrypoint.sh
+          bash ./entrypoint.sh
+        env:
+          PERSONAL_TOKEN: ${{ secrets.PERSONAL_TOKEN }}
+          PUBLISH_BRANCH: gh-pages
+          PUBLISH_DIR: ./dist
+          INPUT_COMMITMESSAGE: 'ci: auto deployment from'
+          INPUT_EMPTYCOMMITS: false
diff --git a/.github/workflows/site-cat.yml b/.github/workflows/site-cat.yml
@@ -11,4 +11,4 @@ jobs:
       - uses: ddradar/lgtm-action@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          image-url: "https://user-images.githubusercontent.com/24802730/74030931-9a21ac00-49f3-11ea-872e-374d5bd3e586.jpg"
+          image-url: 'https://user-images.githubusercontent.com/24802730/74030931-9a21ac00-49f3-11ea-872e-374d5bd3e586.jpg'
diff --git a/components/ChartList.vue b/components/ChartList.vue
@@ -50,8 +50,9 @@
 </template>
 
 <script lang="ts">
-import { Vue, Component, Prop } from 'nuxt-property-decorator'
-import { getDifficultyName, Difficulty } from '@/types/difficulty'
+import { Component, Prop, Vue } from 'nuxt-property-decorator'
+
+import { Difficulty, getDifficultyName } from '@/types/difficulty'
 import { getPlayStyleName, PlayStyle } from '@/types/play-style'
 import { StepChart } from '@/types/step-chart'
 

diff --git a/components/GrooveRadar.vue b/components/GrooveRadar.vue
@@ -3,8 +3,8 @@
 </template>
 
 <script lang="ts">
-import { Vue, Component, Prop } from 'vue-property-decorator'
 import Chart from 'chart.js'
+import { Component, Prop, Vue } from 'vue-property-decorator'
 
 @Component({
   components: {

diff --git a/components/ReactiveRadar.vue b/components/ReactiveRadar.vue
@@ -1,8 +1,8 @@
 <script lang="ts">
-import { Mixins } from 'vue-property-decorator'
-import { Component, Prop } from 'nuxt-property-decorator'
 import Chart from 'chart.js'
-import { Radar, mixins } from 'vue-chartjs'
+import { Component, Prop } from 'nuxt-property-decorator'
+import { mixins, Radar } from 'vue-chartjs'
+import { Mixins } from 'vue-property-decorator'
 
 @Component({})
 export default class ReactiveRadar extends Mixins(Radar, mixins.reactiveProp) {