Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support i18n #243

Merged
merged 7 commits into from
Sep 2, 2020
Merged

feat(client): support i18n #243

merged 7 commits into from
Sep 2, 2020

Conversation

nogic1008
Copy link
Contributor

@nogic1008 nogic1008 commented Sep 2, 2020

part of #148

@nogic1008 nogic1008 added design 🎨 Area UI/UX Design (toolbar, button, text...) enhancement 💬 New feature or request area-client Area @ddradar/web client side labels Sep 2, 2020
@nogic1008 nogic1008 added this to the v1 milestone Sep 2, 2020
@commit-lint
Copy link

commit-lint bot commented Sep 2, 2020

Build System

  • deps: add nuxt-i18n package (6ee59c3)
  • client: add nuxt-i18n settings (def7ecd)
  • deps: add flag-icon-css package (5ffe57c)

Features

  • design: add Flag component (743ce68)
  • client: add lang button on NavBar (b3319da)

Bug Fixes

  • client: change flag button behavior (d724983)

Contributors

@nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-243.eastasia.azurestaticapps.net

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1041      1041           
  Branches       349       349           
=========================================
  Hits          1041      1041           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2c3a0...d724983. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-243.eastasia.azurestaticapps.net

@nogic1008 nogic1008 merged commit 8db5ef1 into master Sep 2, 2020
@nogic1008 nogic1008 deleted the feature/client/i18n branch September 2, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-client Area @ddradar/web client side design 🎨 Area UI/UX Design (toolbar, button, text...) enhancement 💬 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant