Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): use Cosmos DB bindings on more functions #287

Merged
merged 16 commits into from
Sep 25, 2020

Conversation

nogic1008
Copy link
Contributor

No description provided.

@nogic1008 nogic1008 added the refactoring ✨ Not a new feature (code clean, remove dup...) label Sep 25, 2020
@commit-lint
Copy link

commit-lint bot commented Sep 25, 2020

Bug Fixes

Code Refactoring

  • api: use Cosmos DB bindings (5bdd29d)
  • api: remove fetchChartScores() (64adfea)
  • api: avoid use fetchScore() (a86295f)
  • api: use bind on searchSongByName() (2bdc742)
  • api: use mock on test (1c89bb9)

Tests

Contributors

@nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #287 into master will increase coverage by 1.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #287      +/-   ##
===========================================
+ Coverage   98.60%   100.00%   +1.39%     
===========================================
  Files          50        50              
  Lines        1221      1183      -38     
  Branches      376       366      -10     
===========================================
- Hits         1204      1183      -21     
+ Misses         17         0      -17     
Impacted Files Coverage Δ
api/db/index.ts 100.00% <100.00%> (ø)
api/db/scores.ts 100.00% <100.00%> (ø)
api/deleteChartScore/index.ts 100.00% <100.00%> (ø)
api/getChartScore/index.ts 100.00% <100.00%> (ø)
api/getCurrentUser/index.ts 100.00% <100.00%> (ø)
api/postChartScore/index.ts 100.00% <100.00%> (ø)
api/postSongScores/index.ts 100.00% <100.00%> (ø)
api/searchSongByName/index.ts 100.00% <100.00%> (ø)
api/searchSongBySeries/index.ts 100.00% <100.00%> (ø)
client/pages/import.vue 100.00% <0.00%> (+18.64%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d5808...b16aed4. Read the comment docs.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-287.eastasia.azurestaticapps.net

@nogic1008 nogic1008 merged commit 8a7f4fd into master Sep 25, 2020
@nogic1008 nogic1008 deleted the refactor/api/scores branch September 25, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ✨ Not a new feature (code clean, remove dup...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant