Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow upper-cased user id #351

Merged
merged 6 commits into from
Nov 22, 2020
Merged

fix: allow upper-cased user id #351

merged 6 commits into from
Nov 22, 2020

Conversation

nogic1008
Copy link
Contributor

close #344

@nogic1008 nogic1008 added bug 🐛 Something isn't working area-client Area @ddradar/web client side area-api Area @ddradar/web server side labels Nov 22, 2020
@nogic1008 nogic1008 added this to the v1-beta.2 milestone Nov 22, 2020
@commit-lint
Copy link

commit-lint bot commented Nov 22, 2020

Bug Fixes

  • client: enable uppercased user.id (40e6ad9)
  • client: change hasError() (ca9c2f3)
  • api: allow uppercase user id (cf43605)
  • client: fallback 404 (f5e7af0)

Tests

  • client: add uppercase test (f5e3f21)
  • api: add upper-cased user id test (16a3d4c)

Contributors

@nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-351.eastasia.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-351.eastasia.azurestaticapps.net

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #351 (16a3d4c) into master (89d1523) will decrease coverage by 0.03%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   87.57%   87.53%   -0.04%     
==========================================
  Files          81       81              
  Lines        1931     1934       +3     
  Branches      498      498              
==========================================
+ Hits         1691     1693       +2     
- Misses        240      241       +1     
Impacted Files Coverage Δ
client/pages/profile.vue 98.18% <90.90%> (-1.82%) ⬇️
api/db/users.ts 100.00% <100.00%> (ø)
client/pages/users/_id.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d1523...16a3d4c. Read the comment docs.

@nogic1008 nogic1008 merged commit aabac22 into master Nov 22, 2020
@nogic1008 nogic1008 deleted the hotfix/uppercase-id branch November 22, 2020 11:04
@commit-lint commit-lint bot mentioned this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-api Area @ddradar/web server side area-client Area @ddradar/web client side bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot Register ID
1 participant