Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fix wrong isCourse #759

Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix(api): fix wrong isCourse #759

merged 1 commit into from
Sep 17, 2021

Conversation

nogic1008
Copy link
Contributor

GET api/v1/scores/:uid?style=:style&diff=:diff&lv=5&lamp=:lamp&rank=:rank returns wrong isCourse

@commit-lint
Copy link

commit-lint bot commented Sep 17, 2021

Bug Fixes

  • api: fix wrong isCourse (27eddee)

Contributors

nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #759 (27eddee) into master (24fd986) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #759   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        91           
  Lines         2089      2089           
  Branches       555       555           
=========================================
  Hits          2089      2089           
Impacted Files Coverage Δ
api/scores__uid/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fd986...27eddee. Read the comment docs.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-water-096a66800-759.eastasia.azurestaticapps.net

@nogic1008 nogic1008 merged commit 5e64940 into master Sep 17, 2021
@nogic1008 nogic1008 deleted the hotfix/api/is-course branch September 17, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant