Failure due to survey update

[ddsjoberg]

From Thomas Lumley:

You are listed as the maintainers of one or more of these CRAN packages
"convey" "grattan" "gtsummary" "hutils" "iNZightPlots" "iNZightTools" "jstable"
"svyPVpack" "tab" "tableone"

With the forthcoming version 4.1 of the survey package your package has new check errors. I think all these errors are due to the new implementation of svyquantile()

If you just want to make your package pass check with minimal effort, change "svyquantile" to "oldsvyquantile" if "oldsvyquantile" exists (or require version 4.1 of survey). However, the new implementation is better in a number of ways and you might want to use it instead.

You can get the current development version of 'survey' from https://r-forge.r-project.org/R/?group_id=1788

[larmarange]

Do you want to use the old function until the release of survey and then switch to the new version with a certain requirement once survey 4.1 on CRAN

Alternatively we can check the version number of survey to adapt the code accordingly

[ddsjoberg]

I would be fine with either....I guess I have a preference to update to the new version when survey makes it's cran release. What do you think?

[larmarange]

It would be cleaner on the long term Joseph Larmarange Le mar. 29 juin 2021 à 15:03, Daniel Sjoberg ***@***.***> a écrit :

…

I would be fine with either....I guess I have a preference to update to the new version when survey makes it's cran release. What do you think? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHL5I2P7JCN2YGUTEFITVDTVHACBANCNFSM47P5TGPQ> .

[ddsjoberg]

FYI Lumley said he plans to submit to CRAN in mid-July. The new survey version requires R 3.5, and our current min version is 3.4.