Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore functionality in inline_text.tbl_summary(column) #1885

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

ddsjoberg
Copy link
Owner

What changes are proposed in this pull request?

If there is an GitHub issue associated with this pull request, please provide link.
closes #1883


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed: renv::install()
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

Copy link
Collaborator

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! It works very well now! Thanks Daniel ;)

@ddsjoberg ddsjoberg merged commit e293562 into main Aug 5, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the 1883-fct-inline_text-bug branch August 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: inline_text(column) argument doesn't work with fct by level names
2 participants